This repository was archived by the owner on Oct 9, 2020. It is now read-only.
feat(test): add raw browser testing#49
Open
douglasduteil wants to merge 1 commit intosystemjs:masterfrom
Open
Conversation
douglasduteil
force-pushed
the
feat-test-add-raw-browser-testing
branch
from
2d886bc to
96b99a8
Compare
douglasduteil
force-pushed
the
feat-test-add-raw-browser-testing
branch
from
96b99a8 to
8a7cc52
Compare
Contributor
Author
|
It's a really naive approach 😊
|
| "preversion": "npm run test", | ||
| "test": "node test/index.js" | ||
| "test": "npm run test:node && npm run test:browser", | ||
| "test:node": "node test/index.js", |
Member
There was a problem hiding this comment.
Let's rather make this a jspm run test/index.js server test to avoid npm install tape?
Member
|
To avoid installing jspm 3 times, we could just have it installed at the base-level node_modules for running both the build and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #46
I made a horrible hack that reinstall jspm@beta again... but it works :)
I'm a really open to any alternatives 🙏
Cheers 🍺 @guybedford